CampbellGroup / common

Shared campbell lab code.
GNU Lesser General Public License v3.0
8 stars 5 forks source link

pulser save programmed sequence for query #215

Closed fanmingyu212 closed 6 years ago

fanmingyu212 commented 6 years ago

Addresses #213. Pulser server will save the latest programmed sequence and we can read it from pulser server.

jayich commented 6 years ago

I would create a docstring and add a line about what the programmed_sequence attribute is. Also modify the respective function docstrings where it is used.

fanmingyu212 commented 6 years ago

@jayich docstring changes in last commit as requested.

fanmingyu212 commented 6 years ago

@aransfor Could you take a look at my last comment (https://github.com/CampbellGroup/common/pull/215#discussion_r161350769) and let me know what you suggest to do?

aransfor commented 6 years ago

LGTM I'll merge on Monday