CampbellGroup / common

Shared campbell lab code.
GNU Lesser General Public License v3.0
8 stars 5 forks source link

Double on and double off switches cause error #219

Closed aransfor closed 6 years ago

aransfor commented 6 years ago

@theoriginaljuice @davidhucul

https://github.com/CampbellGroup/common/blob/062a2f75b182e6bc9ad110366045f4685756bc11/lib/servers/Pulser2/sequence.py#L70-L79

^^^ This line should see sequenatial 'on' or 'off' switches and extend the sequence to be on and off all the time for instance addttlpulse(TTL3, on_time=1.0us, duration = 2.0 us ) causes a double switching error when combined with addttlpulse(TTL3, on_time=2.0 us ,duration=1.0 us). Instead the logic should create a single pulse equivelant to addttlpulse(TTL3, on_time = 1.0us, duration = 3.0 us

aransfor commented 6 years ago

Fixed with #230