Closed fanmingyu212 closed 6 years ago
Looks fine to me, but @aransfor should review.
@fanmingyu212 I rarely use the camera server to take data and when I do I grab numpy arrays from the server and save them to datavault as numpy binary files (these are small). I need to have @gkchen and @theoriginaljuice check this pull request since they use the camera for actual experiments. I notified them today
@gkchen Could you test the code and give a review of the code when you have time? The code works for @theoriginaljuice and me, so I think we can merge it if it works for you.
Works for us
On Wed, Mar 21, 2018 at 5:21 PM fanmingyu212 notifications@github.com wrote:
@gkchen https://github.com/gkchen Could you test the code and give a review of the code when you have time? The code works for @theoriginaljuice https://github.com/theoriginaljuice and me, so I think we can merge it if it works for you.
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/CampbellGroup/common/pull/223#issuecomment-375138285, or mute the thread https://github.com/notifications/unsubscribe-auth/AHuAOp9-FzwO_vDh-caiLSMwDNW63iVjks5tgu59gaJpZM4Su9fd .
--
Regards,
Gary Chen
@theoriginaljuice @gkchen Thanks for the reviews. I will merge it now.
Addresses #220.
This PR introduces following changes:
images_folder/2018/03/2018_03_17
. Default enabled.