search

CampbellGroup / common

Shared campbell lab code.
GNU Lesser General Public License v3.0
8 stars 5 forks source link

Fixed double switching error for turning on the same TTL channel cons… #230

Closed jchristensen133 closed 6 years ago

jchristensen133 commented 6 years ago

…ecutively. Tested. @aransfor, @jayich , @gregllong have a look at a small fix to the pulser code. Pulser throws and error if you try and turn a TTL channel on when it is set to turn off. Fix creates an extended pulse.

jayich commented 6 years ago

@fanmingyu212 please review.

jayich commented 6 years ago

@theoriginaljuice I don't think we are actually using any TTL pulses (only differential mode). @fanmingyu212 can confirm. Someone using TTL pulses should review.

fanmingyu212 commented 6 years ago

@theoriginaljuice We are not using TTL pulses that turn off and on a channel at the same time step.

Would the pulser still output a double switch error if a pulse ends at t_0 is added after a pulse starts at t_0 on the same channel?

jchristensen133 commented 6 years ago

@fanmingyu212 you raise a good point. The fix I wrote does not work if you program the consecutive TTL pulses out of order. Updated the code to fix this.