Amj/scriptscanner fixes

[jayich]

review: @aransfor , @gregllong

Please take a look. Our experiments seem to run fine.

[aransfor]

@jayich Just to clarify, there are a few classes in this file, https://github.com/labrad/pylabrad/blob/master/labrad/server.py One is labradserver and one is signal(which is quite short). I dont see one inheriting from the other so how can scriptscanner have all the functionality of a server if it doesnt inherit the server as well. Maybe Im confused on what you mean by subclass

[jayich]

ScriptScanner doesn't inherit Signal from pylabrad, it inherits Signals from inside common. I changed the name in https://github.com/CampbellGroup/common/pull/89/commits/6afffa035e5a02c944bf79955e4f8a041231422c because this is confusing. Signals is a base server class for ScriptScanner. The functionality from Signals (changed to ScriptSignalsServer in https://github.com/CampbellGroup/common/pull/89/commits/6afffa035e5a02c944bf79955e4f8a041231422c) probably should not be in this server and inherited, but put directly into ScriptScanner.

[gregllong]

@aransfor I think the idea is that Signals (now called ScriptSignalsServer) is a child class of LabradServer, which means inheriting from Signals alone would make ScriptScanner a legit LabradServer. The Signal object you pointed to is not the same object.

[gregllong]

LGTM

[aransfor]

LGTM