Roadmap to stable release/ v1

Cap-go / capacitor-social-login

One plugin to make login with Google,Apple,Facebook and so on, simple and fast to implement

https://capgo.app

MIT License

25 stars 9 forks source link

Roadmap to stable release/ v1 #69

Open piotr-cz opened 1 week ago

piotr-cz commented 1 week ago

I'd like to replace the @codetrix-studio/capacitor-google-auth package (that is now in the maintenance mode) with this one, however I'm not sure it it's ready for production.

I think that it is, but current versions follow the v0.0.x format, indicating pre-lease development versions, according to sematic versioning:

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

Latest version on npm: 0.0.68 Latest non pre-relase tag: 0.0.69

Moreover it looks like that some breaking changes are coming (https://github.com/Cap-go/capacitor-social-login/pull/57)

Suggestions:

Release version 0.0.69 on npm to sync with repository tags
Update changelog with information about 0.0.68 and 0.0.69 versions
Add note that twitter/ x is available only on iOS
Release stable version 1.0.0 or pre-relase version (ie. 1.0.0-rc.1)
After breaking changes bump major/ minor / pre-release version

riderx commented 6 days ago

Hello, thanks for the feedback, currently we have a stable output for native part. On web part we have issue making the api returning the same, so 69 is an implementation with different system. (Without idtoken) I’m not satisfied of the current release as it will breaking change with all other implementation just to support web. So we are looking for a solution to keep the current implementation while supporting the web one correctly too with offline support. than when we will release v1. It is ready for production and already used in apps in production, that why the current tag is pre release to allow new users test without breaking current one.

twitter implementation will be removed from now as it native sdk are deprecated. We will release implement them after v1 release.

piotr-cz commented 6 days ago

Thank you, just a small note:

the 0.0.69 version doesn't contain any significant changes (like #57 which has not been merged yet) and I think that you just forgot to publish it on npm.

playaz87 commented 5 days ago

I was hoping to use this plugin for a production app, but Google login isn't working on web (#46 ) or Android (#39 ). I appreciate this is a free plugin, but do you have an eta of when it may be fixed? I just need to know if I should start exploring other options before our scheduled release data in late December.

riderx commented 5 days ago

@piotr-cz if you want to test the latest version use 0.0.68-alpha.8 @playaz87 you can also use it for web, it's working. Otherwise you can still use the official SDK in web as that what we wrap anyway. :) We are actively working on it, we just have many use case to take care, and we want to be sure to not break feature for anyone

playaz87 commented 5 days ago

0.0.68-alpha.8 is not working on web.

Login.tsx:90 Uncaught (in promise) Not yet implemented

playaz87 commented 5 days ago

Apologies - it seems 0.0.68-alpha.8 is working on web. I just needed to restart my local server.