bug: Fix sonarcloud issues

[riderx]

Sonarcloud has a report of 59 issues. The goal is to reduce that to 0 by or changing the code or explaining why it's safe.

[riderx]

/bounty 100

[algora-pbc[bot]]

💎 $100 bounty • Capgo

Steps to solve:

1. Start working: Comment /attempt #163 with your implementation plan
2. Submit work: Create a pull request including /claim #163 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Additional notes:

ℹ️ If something is not clear ask before working on it, otherwise your chance to rework it is high 🎥 To claim you need to provide in your PR a demo video of the change 👨‍👩‍👧‍👦 Join the Discord to get help 📏 Check all Bounty rules

Thank you for contributing to Cap-go/capacitor-updater!

Add a bounty • Share on socials

Attempt	Started (GMT+0)	Solution
🟢 @pranjalg13	Aug 12, 2023, 6:08:39 PM	WIP
🟢 @pbkompasz	Aug 14, 2023, 3:28:18 PM	WIP
🔴 @rishi-raj-jain	Aug 18, 2023, 8:49:04 PM	WIP
🔴 @archie9211	Oct 10, 2023, 6:24:21 PM	WIP
🟢 @ologbonowiwi	Oct 16, 2023, 8:00:44 PM	#289

[ujwalkumar1995]

Hey @riderx Do you mind sharing where we can see the list of issues?

[riderx]

sorry i thinked it was present in my message. here you go: https://sonarcloud.io/project/overview?id=Cap-go_capacitor-updater

[ujwalkumar1995]

@riderx Thank you. I will start working on this. Might not be able to complete all of the issues. Will try to resolve to the best of my capability.

[harishkadamudi]

@riderx , is this still open?

[riderx]

Yes

[pranjalg13]

@riderx can i work on this had raised a request earlier for the same, but somehow got deleted Thanks

[pranjalg13]

I want to know what are the required changes since it mentions there are 60 issues on sonarcloud

[pbkompasz]

/attempt #163

Options

• Cancel my attempt

[algora-pbc[bot]]

Note: The user @pranjalg13 is already attempting to complete issue #163 and claim the bounty. If you attempt to complete the same issue, there is a chance that @pranjalg13 will complete the issue first, and be awarded the bounty. We recommend discussing with @pranjalg13 and potentially collaborating on the same solution versus creating an alternate solution.

[riderx]

Please guys be mindful that only one person would be paid, so don't work for free. The goal is to fix as much as you can and if some don't make sense explain why. The code has to build after your change and still work as expected

[pbkompasz]

Sorry, I only looked for a /attempt comment. I did not see that there was an attempt already. Is there any documentation on how to build the ios plugin?

[riderx]

or with npm command verify or with android studio and xcode, like any native project

[pranjalg13]

Hey @pbkompasz you can try this if you want, leaving the issue to you Thanks

[rishi-raj-jain]

I see no one working on this actively, /attempt #163

Options

• Cancel my attempt

[archie9211]

/attempt #163

Options

• Cancel my attempt

[archie9211]

@riderx Just wanted to know if this issue is still open to work and claim bounty. Thank you

[algora-pbc[bot]]

💡 @ologbonowiwi submitted a pull request that claims the bounty. You can visit your org dashboard to reward.

[ologbonowiwi]

Hey folks! Since we're not having any activity here, I'm attempting this

/attempt #163

Options

• Cancel my attempt

[ologbonowiwi]

Can you review #289 @riderx?

The variable name rule is the only rule that makes more sense to disable.

CONSTANT_NAME is a convention to most languages we use; ignoring the Swift community convention rather than the cap-go convention here makes more sense.

If you find anything that needs to be changed on my PR, let me know :smile:

[KumarNayan]

@riderx Is this bounty still open ? I see 64 code smells.