Cap-go / capacitor-updater

Live update for capacitor apps
https://capgo.app
Mozilla Public License 2.0
471 stars 103 forks source link

Update types #332

Closed bosh-code closed 2 months ago

bosh-code commented 2 months ago

Update the types and JSDocs for this plugin.

Contains "breaking" changes for any users using typescript as some of the interface names have changed and the usage will need to be updated, however this should have no effect on code execution.

Happy to discuss feedback.

riderx commented 2 months ago

Hey thanks for the update, i wonder why did you removed the licence in the file?

bosh-code commented 2 months ago

Hey thanks for the update, i wonder why did you removed the license in the file?

No worries, as long as you are shipping the license with the package, which you are, there's nothing more that needs to be done. Its not standard practice to include license docs at the beginning of source files.

riderx commented 2 months ago

License is very important for the project. This kind of thing cannot be done without discussion. The current license requires this exact behavior to be done for the plugin. Secondly, you removed only in one place, what is not really consistent. So can you put it back ?

riderx commented 2 months ago

Here is the link if you want to learn about MPL: https://www.mozilla.org/en-US/MPL/2.0/FAQ/ CleanShot 2024-03-18 at 23 27 09@2x

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

bosh-code commented 2 months ago

Sure no worries, added it back.

riderx commented 2 months ago

thanks !