search

Cap-go / capacitor-updater

Capacitor plugin for Instant updates: Ship updates, fixes, changes, and features within minutes
https://capgo.app
Mozilla Public License 2.0
532 stars 107 forks source link

R&D download before start first open #72

Closed riderx closed 1 year ago

riderx commented 2 years ago

TO have the same behavior as Burger king app IMG_4103 We could use a wording like : 'We are optimizing your app experience'

meilechwieder commented 2 years ago

This is R&D for auto-update, note for manual is it's already possible.

riderx commented 1 year ago

/bounty $100

algora-pbc[bot] commented 1 year ago

💎 $100 bounty created by riderx 🙋 If you start working on this, comment /attempt #72 to notify everyone 👉 To claim this bounty, submit a pull request that includes the text /claim #72 somewhere in its body 📝 Before proceeding, please make sure you can receive payouts in your country 💵 Payment arrives in your account 2-5 days after the bounty is rewarded 💯 You keep 100% of the bounty award ℹ️ If something is not clear ask before working on it, otherwise your chance to rework it is high 👨‍👩‍👧‍👦 Join the Discord to get help 🙏 Thank you for contributing to Cap-go/capacitor-updater!

Attempt Started (GMT+0) Solution
🟢 @ayewo Aug 9, 2023, 7:40:00 PM #242
aazam-gh commented 1 year ago

Hello, I'd like to work on this issue :)

riderx commented 1 year ago

Hi @Alcadeus0 that awesome ! please feel free to ask here any missing info

aazam-gh commented 1 year ago

@riderx How do I reproduce this issue?

riderx commented 1 year ago

@Alcadeus0 you can use the demo app: https://github.com/Cap-go/demo-app

Acceptance criterial:

aazam-gh commented 1 year ago

@riderx running npx cap verify gives me image why isn't the pod being found?

riderx commented 1 year ago

this command run from the CI and in local, did you run the command in the root folder?

aazam-gh commented 1 year ago

yes I'm running in the root folder, maybe that's why

riderx commented 1 year ago

mmm ok sorry, you have to have the package manager cocoa pods and use a mac. This task is pretty hard, good knowledge in ios/android is recommended. plus you have to understand capacitor env

aazam-gh commented 1 year ago

@riderx i see that's understandable. I use Ubuntu so it won't be possible even if i decide to use a vm with mac OS. You can un-assign me from the issue

riderx commented 1 year ago

I can grant you of half the price if you find a solution in android

aazam-gh commented 1 year ago

Sure, I'll give it a shot

ayewo commented 1 year ago

Hi @meilechwieder,

Regarding your earlier comment:

This is R&D for auto-update, note for manual is it's already possible.

If you have a moment, mind sharing more details how you currently do it manually?

ayewo commented 1 year ago

Here goes nothing while I /attempt #72 .

Options
riderx commented 1 year ago

Hey @ayewo I made half of this working, it's done in IOS, I still have some issue in Android. Have you something on your side ? Maybe we can join forces

ayewo commented 1 year ago

Hi @riderx

Maybe we can join forces

You've already done 50% do I really have a choice 😀?

Since you've coded the iOS implementation, perhaps you could share it so I can translate it for Android.

riderx commented 1 year ago

I'm sorry, I really needed it, and a shower showed me the way ^^. I just finished the Android part as well 5 min ago.

So the bounty in this state is not available anymore. I would more now try to battle test it, and be sure this work 100% of the time. Can you help on that ? I can do 100 bounty for this

ayewo commented 1 year ago

Haha @ shower thoughts 😁

Sure. I updated the capacitor-related dependencies for the demo-app from v4.x.x to v5.x. and will share that later.

Is that what you used for initial testing.

riderx commented 1 year ago

i use prod app but you can use this one too

algora-pbc[bot] commented 1 year ago

💡 @ayewo submitted a pull request that claims the bounty. You can visit your org dashboard to reward.

ayewo commented 1 year ago

Hey Martin @riderx,

Testing on iOS and Android ended up taking quite a bit of time ... I think some refactoring and/or some unit tests will be useful—especially for the partial download feature—as I ran into some scenarios where some bundles were failing to delete.

Miscellaneous Issues

riderx commented 1 year ago

I think you are right i never tested end to end local env so that could be broken, if you need time to fix it i can do bounty for that

ayewo commented 1 year ago

The demo app worked on both iOS and Android in my testing. Had to fix a minor logic bug in the demo app (the Splashscreen was shown too quickly, an if block never got called) and fixed a minor bug in the iOS plugin.

For the miscellaneous issues, I can open a separate ticket for them later as they’ll require time for me to investigate and fix them.

Right now, I’m trying to complete the work I started on #119 so please accept the PRs I opened for this issue:

Thanks!

algora-pbc[bot] commented 1 year ago

🎉🎈 @ayewo has been awarded $100! 🎈🎊

FernetB commented 8 months ago

Hi!, i have a question

Where i can see how to make a loading page with auto update: true and direct: true?

riderx commented 8 months ago

You can find it here: https://capgo.app/docs/plugin/force-update/#direct-update