CarlosGS / Cyclone-PCB-Factory

Cyclone (Circuit Cloner) is a parametric CNC mill design intended for PCB manufacturing.
https://reprap.org/wiki/Cyclone_PCB_Factory
1.15k stars 342 forks source link

Is the BoM actual? #54

Closed czapeczek closed 7 years ago

czapeczek commented 8 years ago

I printed all the parts. It seems 2 gears not fit the M8 threaded rod and even the motor head. So either BoM is not actual or something is not to scale with this gears.

I mean here gears for Z axis.

veelck commented 8 years ago

As far as I managed to check this issue, it seems that Cycl_Z_carriage.scad has a bug, where it has the cyclone_rod_gear call - it uses tolerance=0, where in case of X and Y axis there is tolerance set to screwHoleTolerance.

As for the second gear, it seems like the diameter of stepper motor rod is hardcoded inside the standard_parts.scad, which seems strange as I'd expect it to be configured. It also has tolerance=0, but modifying that sets the tolerance on both holes (the motor rod as well as screwing hole, which is not really ideal). Since this is the only gear of this kind, I'm not sure if tolerance should be set there as well, but other motor gears have it set.

I'd love to issue a pull request, but I'm not sure if my changes will make sense, since I'm noob in scad (started to figuring it out like 2h ago ;))

I'd love to get some feedback before I'll issue the PR.

veelck commented 8 years ago

I added the tolerance = screwHoleTolerance for both gears, printed them and it worked like a charm, so I guess that's the problem.

CarlosGS commented 8 years ago

@veelck Thanks for the PR! Would you mind updating the STL with the gears as well?

Interestingly enough, most complains regarding the tolerances so far have pointed out they were too large. So maybe these gears were an exception because of the bug

Thanks to both for the bug report!

veelck commented 8 years ago

@CarlosGS Hi, thanks for taking the PR.

Can you give me some tips on how to optimally generate the STLs? Like I mentioned, I'm new to OpenSCAD and I'm not sure how can I make it so it makes sense (for the gears I needed I exported them one-by-one, so for all the gears that'd be pain in the a..., hope it's not the only way...)

CarlosGS commented 8 years ago

Unfortunately that is the case, STLs need to be manually generated for every part. What I often do, is render an STL for the full machine, then load it in Cura and choose "split into parts", finally arrange the parts into the proper alignment for 3D printing

I agree, it is tedious. But if you still have around the updated STLs, what I'd do is load the old gear plate in Cura, then choose "split into parts", remove the Z gears, then drop the new STLs into Cura, and finally save the new STL plate Sorry for the inconvenience, it would be great to have a way to automate this, indeed

CarlosGS commented 7 years ago

Merging this issue with #57