Line History - image in split screen out of sync with the line selected

[Domhnall101]

When viewing a line in line history the assorted line states are shown in the split screen. a cropped image selection is also shown. This line is out of sync with the actual line being shown. The line above is presented. Looks like the calculation is off for the selection as the bounding boxes look to be the right shape

[thehabes]

This is adjustBookmark(). It takes an archived line for these calculations. Check here.

[thehabes]

I think this may have already been inadvertently fixed. I am testing on /TPEN28/.
projectID=5555 projectID=4080 Do not exhibit this behavior any more. I dont think. Tested with creating new lines, resizing new lines, merging new lines, splitting new lines, resizing already existing lines, merging existing lines, splitting existing lines. It all seemed to work.

[Domhnall101]

nope

On Mon, Mar 27, 2017 at 11:56 AM, Bryan Haberberger < notifications@github.com> wrote:

I think this may have already been inadvertently fixed. I am testing on /TPEN28/. projectID=5555 projectID=4080 Do not exhibit this behavior any more. I dont think. Tested with creating new lines, resizing new lines, merging new lines, splitting new lines, resizing already existing lines, merging existing lines, splitting existing lines. It all seemed to work.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_CenterForDigitalHumanities_TPEN28_issues_423-23issuecomment-2D289515408&d=DwMFaQ&c=Pk_HpaIpE_jAoEC9PLIWoQ&r=H-pvvm1AeDS_YWl-1yRNHg&m=-8XNlI4jklmSD4gPbBRyjvHietoZ2lIHBkKrOxnHrzo&s=-tJMqcW_X5tP1NuBqpH2ftUCEK3io-bnsSDIIzyunjs&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AQaFPYOvgJFPM-2Dkvuv3vzi27F3In2dADks5rp-2Do0gaJpZM4Mbxx7&d=DwMFaQ&c=Pk_HpaIpE_jAoEC9PLIWoQ&r=H-pvvm1AeDS_YWl-1yRNHg&m=-8XNlI4jklmSD4gPbBRyjvHietoZ2lIHBkKrOxnHrzo&s=JQF-1pfjmaVaJKAArNDxLbDyZpnr5koM7X3erQSTweM&e= .

-- Donal Hegarty Project Manager/UX Designer Walter J. Ong S.J. Center for Digital Humanities Saint Louis University 314 9774248

[Domhnall101]

projectID=5229 projectID=5228

On Mon, Mar 27, 2017 at 11:59 AM, Domhnall Ó h'Éigheartaigh < dhegarty@slu.edu> wrote:

nope

On Mon, Mar 27, 2017 at 11:56 AM, Bryan Haberberger < notifications@github.com> wrote:

I think this may have already been inadvertently fixed. I am testing on /TPEN28/. projectID=5555 projectID=4080 Do not exhibit this behavior any more. I dont think. Tested with creating new lines, resizing new lines, merging new lines, splitting new lines, resizing already existing lines, merging existing lines, splitting existing lines. It all seemed to work.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_CenterForDigitalHumanities_TPEN28_issues_423-23issuecomment-2D289515408&d=DwMFaQ&c=Pk_HpaIpE_jAoEC9PLIWoQ&r=H-pvvm1AeDS_YWl-1yRNHg&m=-8XNlI4jklmSD4gPbBRyjvHietoZ2lIHBkKrOxnHrzo&s=-tJMqcW_X5tP1NuBqpH2ftUCEK3io-bnsSDIIzyunjs&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AQaFPYOvgJFPM-2Dkvuv3vzi27F3In2dADks5rp-2Do0gaJpZM4Mbxx7&d=DwMFaQ&c=Pk_HpaIpE_jAoEC9PLIWoQ&r=H-pvvm1AeDS_YWl-1yRNHg&m=-8XNlI4jklmSD4gPbBRyjvHietoZ2lIHBkKrOxnHrzo&s=JQF-1pfjmaVaJKAArNDxLbDyZpnr5koM7X3erQSTweM&e= .

-- Donal Hegarty Project Manager/UX Designer Walter J. Ong S.J. Center for Digital Humanities Saint Louis University 314 9774248 <(314)%20977-4248>

-- Donal Hegarty Project Manager/UX Designer Walter J. Ong S.J. Center for Digital Humanities Saint Louis University 314 9774248

[thehabes]

There are potentially multiple days of work involved with fixing this fully. The resize math on it is wrong, and the calculations as to why the drawn line is off is very tricky. It has to do with how the elements are built and positioned in the html and how it is trying to use pixel values instead of percentages and how the height of the image is not represented correctly because it is overruled by its parents. The UI needs to be moved around so that the percentages can be applied to the drawn line relative to the new calculated sizes off the original ratio between the images, and the HTML elements that contain them need to size based off these calculations.

Once the UI is rearranged, I can then see why the math is off and attempt to fix it. Right now, I can't tell if the problems are coming from Math (and if so whether the height or the top is causing the problem) or from the HTML not positioning the elements correctly to size off of each other.,

[Domhnall101]

Hold untill pat come back on Monday. He had a good idea what the issue was specifically

On Mon, Mar 27, 2017 at 1:50 PM, Bryan Haberberger <notifications@github.com

wrote:

There are potentially multiple days of work involved with fixing this fully. The resize math on it is wrong, and the calculations as to why the drawn line is off is very tricky. It has to do with how the elements are built and positioned in the html and how it is trying to use pixel values instead of percentages and how the height of the image is not represented correctly because it is overruled by its parents. The UI needs to be moved around so that the percentages can be applied to the drawn line relative to the new calculated sizes off the original ratio between the images, and the HTML elements that contain them need to size based off these calculations.

Once the UI is rearranged, I can then see why the math is off and attempt to fix it. Right now, I can't tell if the problems are coming from Math (and if so whether the height or the top is causing the problem) or from the HTML not positioning the elements correctly to size off of each other.,

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_CenterForDigitalHumanities_TPEN28_issues_423-23issuecomment-2D289548646&d=DwMFaQ&c=Pk_HpaIpE_jAoEC9PLIWoQ&r=H-pvvm1AeDS_YWl-1yRNHg&m=ARGaw2zAV1mLqb1B5MY4gbIvZO23cG5-I0oZlRZkIlA&s=VrVTFf-UPjjHCuY74p2FNWoECPrzM7Y99WwPybS85xA&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AQaFPQ94Dx6oyZgVx6vGJtq6SaitPeusks5rqATygaJpZM4Mbxx7&d=DwMFaQ&c=Pk_HpaIpE_jAoEC9PLIWoQ&r=H-pvvm1AeDS_YWl-1yRNHg&m=ARGaw2zAV1mLqb1B5MY4gbIvZO23cG5-I0oZlRZkIlA&s=muygm60a9iK7IGegh8gERIVpzcnULwV8RYLQmtCsp2c&e= .

-- Donal Hegarty Project Manager/UX Designer Walter J. Ong S.J. Center for Digital Humanities Saint Louis University 314 9774248

[thehabes]

The math is sound once you take away the pixel vs. percentage incongruities.
I moved around the HTML elements so the proper sizes are put correctly to the HTML elements.
This has fixed the issue, but caused a couple other UI things I need to fix,

[thehabes]

Up for testing on /TPEN28/