CentreForDigitalHumanities / procreg

Data processing registration Django app
0 stars 0 forks source link

New basetemplate and navbar #49

Closed tymees closed 11 months ago

tymees commented 11 months ago

This PR refactors the base templates by adding a new 'master' base template which combines common elements of the existing three base templates. This new base template also extends DSC's tool base template instead of the site one, with the required header changes. (Some site_base.html specific helper files were also removed as they are now unused). The three existing templates are now extensions of this new master template.

I've also changed the existing base templates by removing the custom uu-content implementation. Instead, the cover and hero content blocks are now in the pre-messages-content content-block and the rest now uses content from the tool_base.html template. I think the custom uu-content implementation is a leftover from when DSC didn't have a solution for this content-ordering problem, so I thought it best to switch over now that it does exist.

As a bonus:

There are some things I noticed, which may require further changes:

I didn't change those yet, because you might have a good reason for doing it this way.

miggol commented 11 months ago

the landing page was cleaned up and a spacing issue in the 'steps' row was fixed.

Also thank you for this!

tymees commented 11 months ago

If you are happy to do the additional work, I'll merge this :)