search

CesiumGS / cesium-native

Apache License 2.0
415 stars 210 forks source link

Fix `PropertyAttributeView::forEachProperty` #755

Closed lilleyse closed 10 months ago

lilleyse commented 10 months ago

Fixes PropertyAttributeView::forEachProperty. The parameter order just needed to be swapped.

csciguy8 commented 10 months ago

Looks like a good fix @lilleyse.

Would be nice if our unit tests caught these compile errors first though. @j9liu any ideas?

j9liu commented 10 months ago

@csciguy8 Yeah I didn't write tests for forEachProperty for any of the property views. It seemed a little awkward to test because each property is of a different type, so if we were going to thoroughly test multiple properties then you'd have to write a super specific / big callback.

I don't think that it should fall on @lilleyse to fix that so I'm happy to merge once CI passes. Thanks for the catch!