Change `FeatureIdTextureView` to account for sampler wrap values in `getFeatureID`

CesiumGS / cesium-native

Apache License 2.0

414 stars 210 forks source link

Change `FeatureIdTextureView` to account for sampler wrap values in `getFeatureID` #793

Closed azrogers closed 7 months ago

azrogers commented 7 months ago

Fixes #741.

Previously, FeatureIdTextureView acted like the feature ID texture's sampler always had CLAMP_TO_EDGE specified as its wrap mode, even when this wasn't the case. This change makes FeatureIdTextureView apply the sampler's wrap mode before sampling the texture, using the same method as PropertyTexturePropertyView.

azrogers commented 7 months ago

@j9liu Incorporated the changes you recommended and updated CHANGES.md!

j9liu commented 7 months ago

Thanks @azrogers ! I just readded the const to getFeatureID's declaration. Merging now.