Replace zlib with zlib-ng

CesiumGS / cesium-native

Apache License 2.0

414 stars 210 forks source link

Replace zlib with zlib-ng #798

Closed azrogers closed 6 months ago

azrogers commented 7 months ago

Closes #707.

This change replaces the dependency on zlib with zlib-ng. This is a fork of zlib with improved performance, including support for hardware acceleration. It also adds tests to the CesiumUtility Gunzip implementation.

jherico commented 7 months ago

@kring zlib-ng is available in VCPKG as well. Should I incorporate these changes into my VCPKG PR?

kring commented 7 months ago

@jherico we haven't reviewed this yet, but I suspect it should be a pretty decent win with no downside, so I think yes, we'll want it in the vcpkg PR eventually. I don't want to create work for you when we haven't even given you the review we owe you yet, though!

kring commented 6 months ago

Thanks @azrogers!