Attach KHR_texture_transform to other extensions

CesiumGS / cesium-native

Apache License 2.0

414 stars 210 forks source link

Attach KHR_texture_transform to other extensions #802

Closed lilleyse closed 6 months ago

lilleyse commented 7 months ago

Partially addresses https://github.com/CesiumGS/cesium-native/issues/801.

Updates the generator code to register KHR_texture_transform on ExtensionExtFeatureMetadataFeatureIDTexture and PropertyTextureProperty but does not update FeatureIdTextureView or PropertyTexturePropertyView.

j9liu commented 7 months ago

@lilleyse should this extend FeatureIdTexture for EXT_mesh_features too? I see that this extends the legacy EXT_feature_metadata texture but not the newer one

lilleyse commented 7 months ago

Oh yes it should. Thanks for catching that.

lilleyse commented 7 months ago

Hm, so the problem is that featureIdTexture.schema.json is in both extensions and it ends up picking whichever one was added to the schema base paths first...

At this point maybe we can just drop support for the older extensions?

j9liu commented 7 months ago

Hm that's probably fine! No one has complained about them not being supported in our clients (yet?)

lilleyse commented 7 months ago

I opened a PR to remove EXT_feature_metadata: https://github.com/CesiumGS/cesium-native/pull/812. Once that's merged I'll update this PR.

lilleyse commented 7 months ago

@j9liu updated!

kring commented 6 months ago

Merging this in order to move on to #811. Thanks @lilleyse! And thanks @j9liu for all the review work.