search

CesiumGS / cesium-native

Apache License 2.0
414 stars 210 forks source link

Remove Pull Request triggers for CI builds #810

Closed csciguy8 closed 6 months ago

csciguy8 commented 7 months ago

It's not obvious to me why this is needed.

It's also a little annoying (and wasteful) to have a PR created, push commits to it, and see two builds get triggered.

kring commented 6 months ago

The pull_request builds are useful when someone creates a PR from a fork. For example, here's a PR that only has pull_request builds: https://github.com/CesiumGS/cesium-native/pull/786

I'm not sure if there's a way to avoid the duplicate-ish (they're not identical if main has changed since the PR's branch was created) build from in-repo commits.

csciguy8 commented 6 months ago

Makes sense. @kring says this type of problem goes back to the early days of CesiumJS too.

I don't think it's a big enough problem to spend any more time on. Closing this without merging.