CesiumGS / cesium-native

Apache License 2.0
402 stars 205 forks source link

Fix compiling in GCC 13 #829

Closed lilleyse closed 5 months ago

lilleyse commented 5 months ago

A few changes so that cesium-native compiles in GCC 13 (I tested with 13.1.0). I confirmed that it still compiles with GCC 9 and GCC 11.

timoore commented 5 months ago

I would turn off those warnings globally at the CMake level rather than in just the files where they are causing false positives now. I believe that these have a pretty bad reputation.

lilleyse commented 5 months ago

I moved dangling-reference to CMake but kept stringop-overflow in the code since there are already other pragmas surrounding <picosha2.h>

j9liu commented 5 months ago

I don't have GCC set up to try this locally, but these changes look good + make sense to me. Thanks @lilleyse !