Closed lilleyse closed 5 months ago
I would turn off those warnings globally at the CMake level rather than in just the files where they are causing false positives now. I believe that these have a pretty bad reputation.
I moved dangling-reference
to CMake but kept stringop-overflow
in the code since there are already other pragmas surrounding <picosha2.h>
I don't have GCC set up to try this locally, but these changes look good + make sense to me. Thanks @lilleyse !
A few changes so that cesium-native compiles in GCC 13 (I tested with 13.1.0). I confirmed that it still compiles with GCC 9 and GCC 11.
-Wstringop-overflow
when includingpicosha2.h
-Wdangling-reference
which was causing false positives in test files<cstdint>
in more places