Closed drewtu2 closed 5 months ago
This might be covered by https://github.com/CesiumGS/cesium-native/pull/829
Hi @drewtu2,
Thank you for your contribution! We just merged #829, so I'd suggest syncing with main and letting us know if it works. But based on the number of Files Changed, your PR might have additional changes that weren't included in #829.
We won't be able to review this PR until we have a signed CLA from you. Once signed, we'd be happy to take a look!
after syncing and comparing, it looks like #829 addressed these changes as well. Closing this PR since it's already been fixed.
Adds the
#include <cstdint>
header to a handful of headers to build successfully on linux. This does not address a similar issue in with the Draco library which is mentioned in the linked issue. I will open a separate PR for that.Built with Ubuntu 18.04 w/ gcc 14.0, cmake 3.29
This issue is discussed in https://github.com/CesiumGS/cesium-native/issues/765
Additional note: I need to remove the
-werror
to get this to build successfully. It seems like there are additional issue with some of the sign conversions that throw warnings, however that is not addressed in this PR.