Closed csciguy8 closed 4 months ago
Looks like the Unreal 5.3 build system is having a hard time with this code...
Compilation is fine with spdlog 1.10, but any later version shows this compile error.
So the cesium-unreal (UE 5.3) build problems go away if updating build settings in that repo to V4. This is probably something we want to do anyway. Unfortunately, haven't discovered a solution for UE 5.1 yet.
Not really seeing any other way of getting spdlog to compile. has_format_as
isn't driven by any other compile settings.
This PR is ready for a look.
In the end, decided to wait on updating spdlog until cesium-unreal can support this upgrade. The notes in this PR will be helpful for that.
Also, allowing an externally supplied spdlog is still a valuable feature, even if spdlog itself isn't upgraded.
Thanks @csciguy8!
Based off original community contribution in this PR.
This PR makes the following changes:
Investigates updating spdlog to 1.13.0, but this proved to be incompatible with Unreal 5.1 at this time. I think we can update once UE 5.3 becomes our minimum supported version.