Closed kring closed 4 months ago
- Move the STB image resize implementation code into CesiumGltfReader (instead of CesiumGltfContent). This fixes a weird situation where applications that only depend on
CesiumGltfReader
would get linker errors.
Does this fix https://github.com/CesiumGS/cesium-native/issues/813?
Looks good!
ktx
library instead ofktx_read
. While cesium-native currently only needs the read functionality, by depending onktx_read
cesium-native prevents anything that uses cesium-native from bringing in the write functionality. This is because there's noktx_write
. The only options arektx_read
which is read-only, andktx
which includes both. If you try to link against bothktx
andktx_read
, you'll end up with multiply-defined symbols.CesiumGltfReader
would get linker errors.KTX_FEATURE_TOOLS
to off. This saves a bit of time, and also stops KTX from bringing in its only implementation of cxxopts.