search

CesiumGS / cesium-native

Apache License 2.0
402 stars 205 forks source link

Fix cmake issue with KTX and iOS #869

Closed csciguy8 closed 3 months ago

csciguy8 commented 3 months ago

Showed up in cesium-unreal as this cmake error...

CMake Error at cesium-native/CMakeLists.txt:210 (install): install TARGETS given no FRAMEWORK DESTINATION for static library FRAMEWORK target "ktx". (link to CI run)

Setting FRAMEWORK DESTINATION explicitly seems to fix it.

Also remove previous line that set PROPERTIES PUBLIC_HEADER to fix the install. This doesn't seem to be needed anymore as the cmake generation works without it

j9liu commented 3 months ago

Thanks so much @csciguy8. I can confirm that removing the PROPERTIES PUBLIC_HEADER check still results in valid compilation in our runtimes, but I'll tag @kring for a gut check since he was the one who added support for it. (I imagine he put that in as necessary for his own environment.)

csciguy8 commented 3 months ago

@j9liu Ready for another look.

Added a comment for the change, indicating its requirement for iOS.

j9liu commented 3 months ago

Thanks @csciguy8 :pray: Happy to merge once CI completes.