CesiumGS / cesium-native

Apache License 2.0
391 stars 200 forks source link

Various glTF fixes, mostly meshopt related #875

Closed kring closed 1 month ago

kring commented 2 months ago

EXT_meshopt_compression is fun because it is, as far as I'm aware, the only thing other than a regular bufferView that can reference a buffer. This wasn't being accounted for in a lot of the glTF manipulation code.

From the changelog:

Draft because I need to write tests for a lot of this, though I have empirical evidence in another project that these changes are necessary and that they are working well.

kring commented 1 month ago

I've addressed @lilleyse's comment and added tests, so this is now ready to review and merge.

lilleyse commented 1 month ago

The macOS runners are taking a while to launch. But everything else passed and the code looks good to me, so I'm going to merge.