search

CesiumGS / cesium-native

Apache License 2.0
391 stars 200 forks source link

Change Windows detection for URI methods. #891

Closed kring closed 1 month ago

kring commented 1 month ago

Instead of:

if constexpr (std::filesystem::path::preferred_separator == '\\')`

We now do:

#ifdef _WIN32

Because the former won't work on versions of iOS prior to 13.0.

See CesiumGS/cesium-unreal#1431

I considered fixing this by ifdef'ing for an old version of iOS specifically, but it would be more complicated and the benefit is vanishingly small.

@csciguy8 originally suggested just using #ifdef _WIN32 here, but I tried to be clever.

j9liu commented 1 month ago

Looks good to me, thanks @kring !