CesiumGS / cesium-native

Apache License 2.0
421 stars 212 forks source link

Add i3dm tests and fix some bugs. #895

Closed kring closed 4 months ago

kring commented 4 months ago

Fixes the glTF 1.0 crash I reported here: https://github.com/CesiumGS/cesium-unreal/pull/1371#issuecomment-2138534687

Before this PR, any errors while loading a glTF would have resulted in a similar crash, and any warnings would have been silently dropped.

I also noticed and fixed two other bugs:

I also wrote a few basic tests of the i3dm converter, because we had none previously.

I'm going to self merge this because it's needed for today's release.

timoore commented 4 months ago

Thanks for getting on this. I started to write similar tests that found the same issue with extensionsUsed et al., but I'll build on yours for additional i3dm tests.