search

CesiumGS / cesium-native

Apache License 2.0
391 stars 200 forks source link

add ray ellipsoid for intersection tests #896

Closed jiangheng90 closed 1 month ago

jiangheng90 commented 1 month ago

since I promise to fulfill screen space for cesium unreal first I need to support ray ellipsoid for intersection tests.

kring commented 1 month ago

Thanks for the PR @jiangheng90! We'll review and merge this soon.

(Cesium folks: we already have a signed CLA from @jiangheng90)

kring commented 1 month ago

Thanks for the quick turn around @jiangheng90! Your changes look good, I'll merge this as soon as CI passes.

j9liu commented 1 month ago

I know this is already merged, but is inverseRadii a typical way of defining an ellipsoid? In my head, I would think it's more intuitive to pass in regular radii, and compute the inverse in the function itself.

But, it's not the biggest deal. The contribution is still appreciated!

jiangheng90 commented 1 month ago

I know this is already merged, but is inverseRadii a typical way of defining an ellipsoid? In my head, I would think it's more intuitive to pass in regular radii, and compute the inverse in the function itself.

But, it's not the biggest deal. The contribution is still appreciated!

I know this is already merged, but is inverseRadii a typical way of defining an ellipsoid? In my head, I would think it's more intuitive to pass in regular radii, and compute the inverse in the function itself.

But, it's not the biggest deal. The contribution is still appreciated!

Already done in #901 I think use radii is better than inverseRadii