search

CesiumGS / cesium-native

Apache License 2.0
421 stars 212 forks source link

Fix uninitialized value and missing include #913

Closed jaadelgren closed 3 months ago

jaadelgren commented 3 months ago

Minor fix for uninitialized values, which will produce an error if the build is set up to treat certain warnings as errors, and a fix for a missing include.

timoore commented 3 months ago

The i3dm fix is in #910 .

jaadelgren commented 3 months ago

The i3dm fix is in https://github.com/CesiumGS/cesium-native/pull/910 .

Gotcha, I didn't see that. Let me know if you'd like me to just revert those changes. I was also getting an error with the missing include, so I could just leave that portion.

timoore commented 3 months ago

The i3dm fix is in #910 .

Gotcha, I didn't see that. Let me know if you'd like me to just revert those changes. I was also getting an error with the missing include, so I could just leave that portion.

I think that's best. The contributor of #910 also handled some rare error conditions in decompose.