search

CesiumGS / cesium-native

Apache License 2.0
414 stars 210 forks source link

Add getFeatureIdAccessorView for instances #934

Closed timoore closed 3 weeks ago

timoore commented 1 month ago

Implement getFeatureIdAccessorView for feature IDs stored in the EXT_mesh_gpu_instancing extension. Refactor the existing function, used for accessing feature IDs in primitives, to use common code.

timoore commented 3 weeks ago

@j9liu this awaits your approval!

timoore commented 3 weeks ago

@j9liu thanks for the Changelog entry; ! forgot!

j9liu commented 3 weeks ago

No worries @timoore ! I also wanted to add one more unit test to catch an invalid case, then I'll merge. Will do that in a bit