CesiumGS / cesium-native

Apache License 2.0
435 stars 213 forks source link

Decide on #include style #991

Open lilleyse opened 4 days ago

lilleyse commented 4 days ago

We're not totally consistent with how we include headers. What about something like this?

It would be great if clang-format could enforce this. In any case, once we agree on something it should go in the C++ Style Guide.

kring commented 4 days ago

Previous issue about this: https://github.com/CesiumGS/cesium-native/issues/80 Which pretty much came to the same conclusion that you wrote above. I think that's been the decision all along, we just haven't enforced it, or retroactively converted all code to that style.

In theory we don't need to put this in the Style Guide, because it's already in the C++ Core Guidelines, which are included by reference. 🤷 https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf12-prefer-the-quoted-form-of-include-for-files-relative-to-the-including-file-and-the-angle-bracket-form-everywhere-else