search

CestDiego / nand2tetris.el

Major Mode for HDL files in nand2tetris.
42 stars 11 forks source link

Avoid using namespace libraries #2

Closed xiongtx closed 7 years ago

xiongtx commented 7 years ago

First, thanks for creating this package--it makes working with the Nand2Tetris course much easier!

I would suggest, however, that namespace libraries like names be avoided. While they may seem convenient, there are some annoying quirks. For example, if I eval-defun on a variable like -assembler, I am actually putting a new value into -assembler, not nand2tetris-assembler.

Also, using customizable variables for directories means that changing the base directory nand2tetris-core-base-dir does not propagate the change to all relevant values and functions. There's really no need for these variables; the script functions should just use nand2tetris-core-base-dir directly.

CestDiego commented 7 years ago

I see. Thank you for your nice feedback. As of this moment I can't work on this right now. But PRs are welcome. I'll make a reminder to work on this by the middle. Of next month though.

On Tue, Sep 27, 2016, 11:57 PM Tianxiang Xiong notifications@github.com wrote:

First, thanks for creating this package--it makes working with the Nand2Tetris course much easier!

I would suggest, however, that namespace libraries like names be avoided. While they may seem convenient, there are some annoying quirks. For example, if I eval-defun on a variable like -assembler, I am actually putting a new value into -assembler, not nand2tetris-assembler.

Also, using customizable variables for directories means that changing the base directory nand2tetris-core-base-dir does not propagate the changes to all relevant functions. There's really no need for these variables; the script functions should just use nand2tetris-core-base-dir directly.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CestDiego/nand2tetris.el/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/ADI544JUFmwXHGAg2jArt-fXhCizBakjks5queWxgaJpZM4KIZGq .

Diego Berrocal http://cestdiego.github.io

CestDiego commented 7 years ago

Fixed in https://github.com/CestDiego/nand2tetris.el/pull/3 @xiongtx thanks for your feedback again.