search

CestDiego / nand2tetris.el

Major Mode for HDL files in nand2tetris.
42 stars 12 forks source link

tests-current-hdl-elsewhere uses hdl files that the function was previously run on #9

Closed davidshepherd7 closed 6 years ago

davidshepherd7 commented 6 years ago

Every time this function runs it copies the target files to /tmp and runs the hardware simulator there. But this means that any files that were previously copied there are still hanging around for future test runs. So the hardware simulator tries to use them instead of the builtin chips.

A simple fix would be to generate a new temp directory each time with (make-temp-file "nand2tetris" t). As a side benefit this would also be more portable: /tmp isn't always the correct temp directory.

It's not really bothering me (I think I'll use tests-current-hdl anyway from now on so that I can see the outputs), but I thought you would like to know.

Thanks for the nice package :+1:.

CestDiego commented 6 years ago

Thanks for the feedback . I unfortunately can't really dedicate time to this at the moment.

It sounds like a perfect Pull Request opportunity and I encourage you to dig into it.

I would be happy to review it and provide feedback. It looks like you have a grasp of elisp already.

On Thu, Nov 30, 2017, 08:58 David Shepherd notifications@github.com wrote:

Every time this function runs it copies the target files to /tmp and runs the hardware simulator there. But this means that any files that were previously copied there are still hanging around for future test runs. So the hardware simulator tries to use them instead of the builtin chips.

A simple fix would be to generate a new temp directory each time with (make-temp-file "nand2tetris" t). As a side benefit this would also be more portable: /tmp isn't always the correct temp directory.

It's not really bothering me (I think I'll use tests-current-hdl anyway from now on so that I can see the outputs), but I thought you would like to know.

Thanks for the nice package 👍.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CestDiego/nand2tetris.el/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/ADI548sut-SjZt0i8TbAylzB_B1ddopWks5s7rSfgaJpZM4Qwlx8 .

-- Diego Berrocal http://diegoberrocal.com