search

ChainSafe / fvm-toolkit

FVM Development Toolkit
2 stars 1 forks source link

Perform basic validation of the created bundle #5

Open boorich opened 1 year ago

boorich commented 1 year ago

Make sure the bundle adheres to our bundle standard like https://github.com/ChainSafe/filix/issues/2#issuecomment-1342645381.

This is more like sanity checking.

This issue needs better specification

stonecharioteer commented 1 year ago

We will need to flesh this out more. What does "basic validation" mean, perhaps list out the steps a developer would have to do to check.

LesnyRumcajs commented 1 year ago
  1. The bundle needs to adhere to our bundle standard like here. This would be more like a sanity check.
  2. I am not convinced how much we want to invest in this step. To nicely validate the WASM bundle, we would most likely need a kind of sandbox that is not currently in scope, where we would invoke the Init Actor and, e.g. try to invoke the constructor method (see bundle installation with Lotus). Plus, if the bundle is seldom invalid, it might not be worth it.

All in all, I'd lower the effort to a day or two or even not mention it and do it as a part of creating the bundle. What do you think?