search

Chandra-MARX / marx

Chandra X-ray Observatory ray-trace simulator
http://space.mit.edu/cxc/marx/
5 stars 4 forks source link

Ensuring the constant ARF for SIMPUT stays constant. #29

Closed jzuhone closed 8 years ago

jzuhone commented 8 years ago

The SIMPUT library's function for taking an ARF from an array simply assigns a pointer to whatever array the user passed in. These ARF arrays were created local to a function, and so there is no guarantee that the contents of their memory will be persistent. Making them static arrays at the top-level resolves this issue.

hamogu commented 8 years ago

Thanks! This is the first MARX contribution that I've received through github :-)

jzuhone commented 8 years ago

Happy to help--sorry about all the noise yesterday. Do you have a time frame for tagging a release 5.3.1? I didn't know if you had other things you wanted to get in as well before then.

hamogu commented 8 years ago

So far, I had not planned on a 5.3.1 at all. The next scheduled release is 5.4 in mid-Dec 2016 just before the Chandra call for proposals. I'll think about a 5.3.1 release and see if there is anything else that should go into it.

jzuhone commented 8 years ago

Only asking because next week I plan to release a new standalone version of my photon simulator package (that used to be in yt but now lives in http://github.com/jzuhone/pyxsim) and I'd like to able to cite a stable MARX version that can be used with it. For yt at least we try to put bugfixes in minor point releases.

hamogu commented 8 years ago

OK, in that case I will do a MARX release later today or next week Tuesday if I don't get to it today.

On 08/05/2016 12:04 PM, John ZuHone wrote:

Only asking because next week I plan to release a new standalone version of my photon simulator package (that used to be in yt but now lives in http://github.com/jzuhone/pyxsim https://github.com/jzuhone/pyxsim) and I'd like to able to cite a stable MARX version that can be used with it.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Chandra-MARX/marx/pull/29#issuecomment-237891412, or mute the thread https://github.com/notifications/unsubscribe-auth/AAecACMgjh-4gzR9pzKa0fplkplOVjdzks5qc18WgaJpZM4Jdxn5.

jzuhone commented 8 years ago

Thanks! If there's anything I can do to help out let me know.