Chandra-MARX / marx

Chandra X-ray Observatory ray-trace simulator
http://space.mit.edu/cxc/marx/
5 stars 4 forks source link

Issue warning when simulation stops due to end of asol #49

Closed hamogu closed 9 months ago

hamogu commented 3 years ago

A simulation stops the exposure time is reached, or, if ExposureTime=0, when NumRays is reached. However, I've found that it also stops when the end of the asol file is reached. That can lead to confusing behaviour where an exact number of photons to be detected is specified in the NumRays parameter (e.g. NumRays=-1000000) but the simulation stops short of that.

The solution is simple: Increase the flux value or provide a longer asol file. However, this behavior can be confusing. Thus, a warning message should be added to the output in this case, or even better, a general message "Simulation stoped because ... was reached" where the reason is filled in for every simulation.

note to self: I discovered this while working on Susmita's project.