Chandra-MARX / marx

Chandra X-ray Observatory ray-trace simulator
http://space.mit.edu/cxc/marx/
5 stars 4 forks source link

Warning message from marxasp can be confusing #53

Closed hamogu closed 9 months ago

hamogu commented 2 years ago

A user reported:

By the way, when MARX runs with DitherModel=FILE, I get the message below but the simulation looks okay.
-- 
*** This simulation did not use the INTERNAL dither model.  Re-run the
    simulation with DitherModel=INTERNAL.
-- 
The mode of DitherModel=FILE is fully supported?

marx can run with either DitherModel=FILE or DitherModel=INTERNAL. If you run marx with DitherModel=INTERNAL, then you have the option to create an ASPSOL file in a CIAO compatible format with marxasp (https://space.mit.edu/cxc/marx/Reference/tools.html?highlight=marxasp#marxasp). That is often helpful because many CIAO tools that you might want to use to process your marx output require an ASPSOL file. However, if you run marx with DitherModel=FILE, then there is no need to run marxasp at all - you already have an ASPSOL file which you put into marx. If you still try to run marxasp, even though it's not needed and does not make sense in this situation, it will give you the warning "This simulation did not use the INTERNAL dither model.".

"This simulation did not use the INTERNAL dither model and thus there is no need to generate a new ASPSOL file." would be more clear. Also, it could be good idea to show where the message is from, like "marxasp: This simulation did not use the INTERNAL dither model and thus there is no need to generate a new ASPSOL file.".