search

Chaparroa / hw_assignment_2

GA-FEWD
0 stars 0 forks source link

Feedback on assignment #2 #1

Open barryross opened 8 years ago

barryross commented 8 years ago

FEWD Week #2 Project: Styling with CSS

Description

_Single-column landing page_ - Relaxr or your own

Student:Alex Chaparro

Project URL: https://github.com/Chaparroa/hw_assignment_2
Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use HTML5 structural elements (nav, header, footer) x
Use a CSS Reset file in addition to your style.css file to style the page x
Use IDs and Classes to to select and style elements on the page x
Style your text with the Google Fonts provided by your style guide x
Follow naming conventions, maintain consistency across .html and .css files and use best practices for naming IDs and Classes x
Indent nested elements to increase your code's readability x
TOTAL: 12/12
barryross commented 8 years ago

Really great work on this assignment Alex! So much great stuff happening here, and great job hitting the technical requirements. One thing I noticed with the fonts was your use of 600 font-weight instead of 800 for the Relaxr logo at the bottom, and the "Get it Now" button...just something to be aware of moving forward. Based on your overall styling throughout the assignment though, it seems to me like you are fairly comfortable using Google Fonts and styling according to the design spec and deserved both marks!