search

CharlieDigital / coderev

CodeRev is a lightweight tool that helps teams conduct technical interviews using code reviews.
https://coderev.app
GNU Affero General Public License v3.0
105 stars 4 forks source link

Disable persistent modal to allow escape key to be used to close dialogs #2

Closed victorgdb closed 11 months ago

victorgdb commented 11 months ago

Thank you for this great project!

When I tried to use the escape key to close a dialog, it's not working. It's because of the persistent dialog option from Qasar. If you are interested in changing this aspect, you might remove this property in SideDialogShell.vue:8

Thanks again for your work

CharlieDigital commented 11 months ago

Good idea!

I've made the change and changed the shell to be non-persistent by default.

The one exception is the PreferencesDialog before the user has explicitly set a notification option.

Thanks for the feedback!