CharlieDigital / coderev

CodeRev is a lightweight tool that helps teams conduct technical interviews using code reviews.
https://coderev.app
GNU Affero General Public License v3.0
112 stars 4 forks source link

Feedback: Random notes #6

Open cmgriffing opened 9 months ago

cmgriffing commented 9 months ago

Fantastic idea with this project. A couple things came up while I was looking at this on stream. I realize this is an MVP, so some of this may already be on your roadmap. I just wanted to show some support and share some thoughts.

In no particular order:

Again, great idea. Looking forward to progress. Feel free to close this Issue whenever you like.

CharlieDigital commented 9 months ago

Great ideas; the Markdown was already on my roadmap.

Not sure how many folks would trust sharing their mail API keys, though.

CharlieDigital commented 9 months ago

image

Added support for Markdown with syntax highlighting.

warrengalyen commented 3 weeks ago

Like @cmgriffing mentioned, importing files would be invaluable.

CharlieDigital commented 3 weeks ago

@warrengalyen What are the thoughts here in terms of folder structure? Should it replicate the structure? Or flatten it?

Have to think through this design a bit.

warrengalyen commented 3 weeks ago

@CharlieDigital I think it should replicate the folder structure if it exists just for compatibility. Ideally the person setting up the repo is going to keep the example simple with no sub folders, but you never know. Maybe for the first iteration keep rendering a flat structure like you already have to get it working and use a single parent node as a default folder in your DB. Lookup Adjacency List Model for storing tree data, this is a pretty common approach.