search

ChickenKyiv / recipe-search-react

We're replicating advanced search for recipe based projects
https://modest-shannon-513067.netlify.com/
1 stars 3 forks source link

submit handler #45

Closed atherdon closed 6 years ago

atherdon commented 6 years ago

will you be able to create a form submission to this api? as told you before - don't have exact name for method that will apply for all filters, so just include backend urls with .env file as we did on your repository.

chauhannishith commented 6 years ago

I think we don't need two boxes for same entry, i mean to say if user has selected all products in haveingredients then we can assume that we can omit others. Similar is the case for other fields

atherdon commented 6 years ago

not agree. I can forgot something and it'll be in the recipe. assume that i'm searching for "chicken"(allowed ingredient). but i don't want to find spicy and hot, so i add "curry" & "chilli papper"(disallowed ingredients). at results page i'll have more better search results. so i think maybe we should change the form layout(or flow how user to fill that form) - but i think "-" sometime is more important the plus for results for this case

atherdon commented 6 years ago

But! maybe we can find a components, that will be a standalone one select, but we'll be able to add their search results to "allowed" and "dissallowed"?

chauhannishith commented 6 years ago

I understand what you are trying to say, it will take some time to understand and make the call

chauhannishith commented 6 years ago

Do you have any api with a large number of recepies where i can test these cases?

atherdon commented 6 years ago

we have a small api server. but maybe it's a good idea to connect to some free recipe apis that we have on market. hold on. i think i have what you need in my notes.

chauhannishith commented 6 years ago

assume that i'm searching for "chicken"(allowed ingredient). but i don't want to find spicy and hot, so i add "curry" & "chilli papper"(disallowed ingredients).

i can tell that this functionality will need much more code than what initially was there, if we have to fetch the ingredients dynamically from an api rather than a static file

atherdon commented 6 years ago

yep, this will be one of our next tasks for this project. but for now - as this is just a static form - static arrays working fine too. but yep, for calling api - we'll need to have ids.

chauhannishith commented 6 years ago

I will try to find some solution to the select boxes as right now it feels like they will just go into deadlock if one is dependent on other as one item when selected in one box will have to be disabled for the other and i am confused that how will it happen without refresh

atherdon commented 6 years ago

good idea. i like it!

chauhannishith commented 6 years ago

Do you want to continue with antd only? I know it looks cool and in some ways might be better but it just seems like normal select would be better and also the size of code will be less

atherdon commented 6 years ago

but it wouldn't have an autocomplete functionality, right? in this case - i'm ok with andt. if you want - mention Rahul to this topic and if he have time - maybe he'll be able to advice you

chauhannishith commented 6 years ago

Ok i will try it as it is and will tell if it is worth it or not

atherdon commented 6 years ago

Thanks! yep, we should try and understand if it fits to our main process

atherdon commented 6 years ago

Btw, quick note. i think we should have some form validation. What do you think? maybe you know some component for it? i google formsy, but never use it. to be honest- i'm a bit sick of forms. build them a lot. so don't want personally dig into in deeply

atherdon commented 6 years ago

37 #40

atherdon commented 6 years ago

@chauhannishith i made this article for you: https://medium.com/groceristar/companies-with-recipe-apis-e9f29a64389c hope it helps

chauhannishith commented 6 years ago

Ok. I think i understand a bit what you want to do. Will send you a message when i setup a test call to confirm if i am on the right track.(though i still don't understand the purpose of holidays)

atherdon commented 6 years ago

holidays is maybe the less important field. but a lot of websites use it, so... Usually it used few times in year. For example - "Best recipes for 4th July" or "Christmas pie". we trying to work on server side of search form, and before holiday was a separated table. but we decided to combine all this fields(selects) into Attributes table. so when we have: +I1+I2+I3-I4+A1+C1(include is a plus, exclude is minus, I = Ingredient, A = Allergy, etc) we'll send only id`s into loopack. so i think this will save some of your times. But that search api is not finished. if you with - i can send you a code repo, to take a look

On 02-Jun-2018 at 12:54 AM, chauhannishith wrote:

Ok. I think i understand a bit what you want to do. Will send you a message when i setup a test call to confirm if i am on the right track.(though i still don't understand the purpose of holidays)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChickenKyiv/recipe-search-react/issues/45#issuecomment-394044143, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDuofPHq5DVOuIiDfdyH8FmB9yTzqks5t4eIpgaJpZM4UM-aC .

chauhannishith commented 6 years ago

I am currently going with EDAMAM, trying with static data, if that works then transferring to selected data should not take much time

atherdon commented 6 years ago

good to know! btw, i hope soon we'll finish our apis, so edamam will be just a biggest competitor :) we'll have ingredients + nutritions data(5000 rows) imported. will test in June i assume

On 02-Jun-2018 at 04:36 AM, chauhannishith wrote:

I am currently going with EDAMAM, trying with static data, if that works then transferring to selected data should not take much time

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChickenKyiv/recipe-search-react/issues/45#issuecomment-394057681, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDiLmsEpgjVttqWGZ_tYlYHZfhhYoks5t4hZAgaJpZM4UM-aC .

chauhannishith commented 6 years ago

The test call is working but i can't find any example of how they need the query string format, can you find it when you wake up? i tried this but seems like this doesnt work

excluded: ["chicken",banan","apple"] or

excluded: "excluded=chicken&excluded=banana"

chauhannishith commented 6 years ago

What do you want me to do in this? Only fetch data or like have a display component with 10 lists(links to full recipe) and prev and next buttons

atherdon commented 6 years ago

you mean in search results? let's display some raw data. like we did with form fields - just showing text.

pagination is a cool idea, but not sure that we should do it at this moment. In other repositories I also have some un-finished components, related to displayin recipe data, so maybe we'll use it a bit later. if you want - you can show pagination component from antd, but please not bind it right now, ok?

chauhannishith commented 6 years ago

ok i will just fetch the data and display the recipe names for now

atherdon commented 6 years ago

good choice! can you create a separated task where we can discuss how we can represent a search results?

On 03-Jun-2018 at 05:52 AM, chauhannishith wrote:

ok i will just fetch the data and display the recipe names for now

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChickenKyiv/recipe-search-react/issues/45#issuecomment-394139104, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDjMbB-NEc_to9M7JOW8KF4maiv3Cks5t43mNgaJpZM4UM-aC .

chauhannishith commented 6 years ago

Sorry the internet is not working properly today, will have to do it tomorrow only

atherdon commented 6 years ago

it's ok, not a problem. maybe it will give me some time and review your prev changes :)

On 03-Jun-2018 at 05:57 AM, chauhannishith wrote:

Sorry the internet is not working properly today, will have to do it tomorrow only

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChickenKyiv/recipe-search-react/issues/45#issuecomment-394139277, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDncqFe0LTzu5ItigiMCTjcJTpPW9ks5t43rLgaJpZM4UM-aC .

chauhannishith commented 6 years ago

image

It will be helpful if you can tell me whats wrong with the last commit

atherdon commented 6 years ago

does it work right now? i saw that you've add a header to axious configuration...

chauhannishith commented 6 years ago

No, it doesn't work. Only ingredients work properly, others give this error

atherdon commented 6 years ago

in order to represent error i should pick some other autocomplete fields, right?

On 07-Jun-2018 at 01:22 AM, chauhannishith wrote:

No, it doesn't work. Only ingredients work properly, others give this error

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChickenKyiv/recipe-search-react/issues/45#issuecomment-395262917, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDswszdcbkwWIvqNcqx4XDw0XLKFQks5t6IBZgaJpZM4UM-aC .

chauhannishith commented 6 years ago

Yes but with atleast one ingredient

atherdon commented 6 years ago

will grab some coffee and will check it deeply

atherdon commented 6 years ago

can you create a video and show me how i can make this error? i cannot recreate this rror

chauhannishith commented 6 years ago

select one ingredient and one allergy and it will show you even in the netlify

atherdon commented 6 years ago

i tried option which you show me at screenshot. hold on, will try at netlify instance

On 07-Jun-2018 at 08:34 AM, chauhannishith wrote:

select one ingredient and one allergy and it will show you even in the netlify

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChickenKyiv/recipe-search-react/issues/45#issuecomment-395339051, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDpMdssdZLlypqhZT-0j7l9cGA4wXks5t6OWJgaJpZM4UM-aC .

chauhannishith commented 6 years ago

we have only permits of 5 hits per minute so that might be the reason you didn't get any

atherdon commented 6 years ago

maybe. did we send 1 request for each form element?

On 07-Jun-2018 at 11:03 AM, chauhannishith wrote:

we have only permits of 5 hits per minute so that might be the reason you didn't get any

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChickenKyiv/recipe-search-react/issues/45#issuecomment-395381320, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDh_ZVExqssvxWXF-kap4d4Es8AiKks5t6QiYgaJpZM4UM-aC .

chauhannishith commented 6 years ago

no, we are sending only one request for all form data not a single element btw did you get that error?

atherdon commented 6 years ago

Should i press search? i tried few times, tried to overload server. will try a different browsers right now

On 07-Jun-2018 at 11:22 AM, chauhannishith wrote:

no, we are sending only one request for all form data not a single element btw did you get that error?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChickenKyiv/recipe-search-react/issues/45#issuecomment-395385896, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDriANBI2TCFWOeH2dbbWbns4R3vzks5t6QzrgaJpZM4UM-aC .

atherdon commented 6 years ago

can you check how much items came for ingredients select? i assume this is the most fat part of data that we fetch from that server....

On 07-Jun-2018 at 11:22 AM, chauhannishith wrote:

no, we are sending only one request for all form data not a single element btw did you get that error?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChickenKyiv/recipe-search-react/issues/45#issuecomment-395385896, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDriANBI2TCFWOeH2dbbWbns4R3vzks5t6QzrgaJpZM4UM-aC .

chauhannishith commented 6 years ago

Yes you have to hit search recipies button The error will be displayed in console

atherdon commented 6 years ago

when i hit search i just got a blank page at netlify. hold on will make a few more attempts. if you wish i can create a video about how it looks on my side. can do it for both - local and netlify versions

atherdon commented 6 years ago

ohh, just refresh as beast and got it at local version. exploring rigth now

atherdon commented 6 years ago

yeah i think we just hit a daily number of requests. maybe for debuggin reasons we should fetch some static data like ingredients and save them as json - while we're testing it?

atherdon commented 6 years ago

But why this error appeared only at submit... i mean if we're fetching data each time when i refresh page - it's strange to have restrictions only when we send q query... maybe they just didn't have all of options, that our form provide? maybe they didn't have exclude attributes...

Case#1 When I pick only chicken it's works well. Case#2 When i pick chicken, tuna - it works too.

Case#3 when i pick chicken, tuna, Cheese - it' give me the same error

I didn't refresh page for each of this case...

When i refresh page and pick logical ingredients Case#4 Broccoli, Tomato, oil - it works fine.

maybe they just haven't recipe with that cases? so it's like a 'No results' response?

atherdon commented 6 years ago

Yep, i suppose this error related to not-logical data, that we put in our form. So it's like - No results. Case#5 i pick Peanut Butter and pick Peanut-free allegy and it give me an error too.

atherdon commented 6 years ago

Btw, you did a great job with sending one request for fetching data for select options! When i was junior - my project lead was angry when i send 64 requests instead of 8 :)

chauhannishith commented 6 years ago

can you check how much items came for ingredients select? i assume this is the most fat part of data that we fetch from that server....

they haven't given any method by which we can fetch the ingredients, they have only given the list of allergies and diets which they have

yeah i think we just hit a daily number of requests

it is 5 requests/ min so we have to just wait a minute