search

Chris-Perkins / Lifting-Buddy

[RELEASED] Customizable iOS App for logging gym days. 🏋️‍♀️
MIT License
8 stars 0 forks source link

Avoid scrollable areas in scroll areas #1

Closed solomon23 closed 6 years ago

solomon23 commented 6 years ago

When doing a session and adding a set. Try to avoid the scrollable area set table and just make the outer box larger. This way you’ll avoid the dreaded scroll area within a scroll area

Chris-Perkins commented 6 years ago

Thanks for the feedback! Good to know someone's using the app :) Are you suggesting the tableview should handle like the "add progression tracker" table in that the table's scrolling function is disabled and simply grows to be the size of all cells?

solomon23 commented 6 years ago

Yea. Or not use a table view and add a “row” and wire it via auto layout. I haven’t looked at the code but I’m guessing autolayout is being used and should grow the parent

Chris-Perkins commented 6 years ago

Alright I believe I understand what you mean. I'm going to group this under the "Workout Start Rework" activity from the readme. This should be done in either 1.3 or 1.4. :)

Chris-Perkins commented 6 years ago

Hey there solomon! I believe the rework has completely fixed this issue, and so I will be closing it. That said, if you have any feedback after the update hits your phone, feel free to reach out and open another issue with your thoughts.

Thanks for using Lifting Buddy! :)