Cidan / BetterBags

A total replacement AddOn for World of Warcraft bag frames, inspired by AdiBags.
MIT License
88 stars 39 forks source link

Opening sidebar for configuring items in a category doesn't show item list for self-created custom categories. #674

Open Daeadin opened 2 months ago

Daeadin commented 2 months ago

Addon Version

v0.3.10

World of Warcraft Version

Retail

Describe the bug

When opening the sidebar for configuring items in a category for self-created custom categories (categories created via typing in the Search bar and hitting Enter), only the 'Configure Search Category' screen appears, which allows you to configure the Category Name, Search Query, and Priority. No list of items is provided even if items already exist within said custom category.

Steps to reproduce

Click Better Bags icon upper right of bags, click Configure Categories, click the arrow next to a self-created custom category.

AMaribo commented 2 months ago

Have you manually added items to a search category?

Daeadin commented 2 months ago

Yes, each of the affected custom categories have items already assigned to them.

On Tue, Sep 3, 2024 at 2:33 PM Alexander Maribo @.***> wrote:

Have you manually added items to a search category?

— Reply to this email directly, view it on GitHub https://github.com/Cidan/BetterBags/issues/674#issuecomment-2327275171, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARMMCQCCIG4CO5QWV5JYONLZUYFJZAVCNFSM6AAAAABNSZEL62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXGI3TKMJXGE . You are receiving this because you authored the thread.Message ID: @.***>

Daeadin commented 2 months ago

I should note, each of these categories were created prior to the latest version of BetterBags and had their items added prior as well.

On Tue, Sep 3, 2024 at 2:34 PM Jeff Mullen @.***> wrote:

Yes, each of the affected custom categories have items already assigned to them.

On Tue, Sep 3, 2024 at 2:33 PM Alexander Maribo @.***> wrote:

Have you manually added items to a search category?

— Reply to this email directly, view it on GitHub https://github.com/Cidan/BetterBags/issues/674#issuecomment-2327275171, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARMMCQCCIG4CO5QWV5JYONLZUYFJZAVCNFSM6AAAAABNSZEL62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXGI3TKMJXGE . You are receiving this because you authored the thread.Message ID: @.***>

qlesz commented 2 months ago

Also window to create custom category dissapeared from option menu (was gonna make new issue but couldn't somehow).

AMaribo commented 2 months ago

Also window to create custom category dissapeared from option menu (was gonna make new issue but couldn't somehow).

This option has been deprecated. To create a new custom category, drag an item to the bag button in the top-left corner of the bag.

qlesz commented 2 months ago

Also window to create custom category dissapeared from option menu (was gonna make new issue but couldn't somehow).

This option has been deprecated. To create a new custom category, drag an item to the bag button in the top-left corner of the bag.

Ok i've just tried that but when i try to remove anything from newly created category i got this error (even after reloading): Message: ...terface/AddOns/BetterBags/frames/sectionitemlist.lua:111: attempt to index field 'data' (a nil value) Time: Tue Sep 3 21:58:44 2024 Count: 2 Stack: ...terface/AddOns/BetterBags/frames/sectionitemlist.lua:111: attempt to index field 'data' (a nil value) [string "@Interface/AddOns/BetterBags/frames/sectionitemlist.lua"]:111: in function `func' [string "@Interface/AddOns/Auctionator/Libs/LibUIDropDownMenu/LibUIDropDownMenu.lua"]:333: in function <...ionator/Libs/LibUIDropDownMenu/LibUIDropDownMenu.lua:299> [string "@Interface/AddOns/Auctionator/Libs/LibUIDropDownMenu/LibUIDropDownMenu.lua"]:344: in function <...ionator/Libs/LibUIDropDownMenu/LibUIDropDownMenu.lua:343>

Locals: (temporary) =

{ modules =
{ } defaultModuleState = true data =
{ } baseName = "BetterBags" enabledState = true defaultModuleLibraries =
{ } name = "BetterBags_Database" orderedModules =
{ } moduleName = "Database" } (temporary) = nil (temporary) = nil (temporary) = "attempt to index field 'data' (a nil value)" database =
{ modules =
{ } defaultModuleState = true data =
{ } baseName = "BetterBags" enabledState = true defaultModuleLibraries =
{ } name = "BetterBags_Database" orderedModules =
{ } moduleName = "Database" } elementData =
{ id = 210814 category = "Chests" } events =
{ modules =
{ } defaultModuleLibraries =
{ } name = "BetterBags_Events" orderedModules =
{ } _eventArguments =
{ } _bucketCallbacks =
{ } _bucketTimers =
{ } _eventQueue =
{ } _messageMap =
{ } _eventHandler =
{ } enabledState = true baseName = "BetterBags" _eventMap =
{ } moduleName = "Events" defaultModuleState = true } ctx =
{ keys =
{ } done = false }

AMaribo commented 2 months ago

The above error will be fixed later today.

AMaribo commented 2 months ago

The removing items error is fixed in v0.3.11, heading out to addon sites now.

qlesz commented 2 months ago

V0.3.12 When i try to expand any of the created custom category i get this error now (also after that error, it keep popping up after every item dropped to the bag until reload): Message: Interface/AddOns/BetterBags/frames/item.lua:301: bad argument #1 to 'DoesItemExist' (Usage: local itemExists = C_Item.DoesItemExist(emptiableItemLocation)) Time: Wed Sep 4 19:18:40 2024 Count: 2 Stack: Interface/AddOns/BetterBags/frames/item.lua:301: bad argument #1 to 'DoesItemExist' (Usage: local itemExists = C_Item.DoesItemExist(emptiableItemLocation)) string "=[C]": in function DoesItemExist' [string "@Interface/AddOns/BetterBags/frames/item.lua"]:301: in functionGetItemContextMatchResult' [string "@Interface/AddOns/Blizzard_ItemButton/Mainline/ItemButtonTemplate.lua"]:462: in function UpdateItemContextMatching' [string "@Interface/AddOns/BetterBags/frames/item.lua"]:383: in functionSetItemFromData' [string "@Interface/AddOns/BetterBags/frames/item.lua"]:285: in function SetStaticItemFromData' [string "@Interface/AddOns/BetterBags/frames/itemrow.lua"]:76: in functionSetItemFromData' [string "@Interface/AddOns/BetterBags/frames/itemrow.lua"]:59: in function SetStaticItemFromData' [string "@Interface/AddOns/BetterBags/frames/sectionitemlist.lua"]:147: in function <...terface/AddOns/BetterBags/frames/sectionitemlist.lua:146> [string "@Interface/AddOns/BetterBags/data/items.lua"]:847: in function <Interface/AddOns/BetterBags/data/items.lua:839> [string "=[C]"]: in functionxpcall' [string "@Interface/AddOns/Blizzard_ObjectAPI/Mainline/ContinuableContainer.lua"]:83: in function <...Blizzard_ObjectAPI/Mainline/ContinuableContainer.lua:75>

... [string "@Interface/AddOns/Blizzard_SharedXML/Shared/Scroll/ScrollBoxListView.lua"]:312: in function `DataProviderContentsChanged' [string "@Interface/AddOns/Blizzard_SharedXML/Shared/Scroll/ScrollBoxListView.lua"]:303: in function <...izzard_SharedXML/Shared/Scroll/ScrollBoxListView.lua:300>

[string "@Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua"]:144: in function <...e/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:143>

[string "@Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua"]:147: in function TriggerEvent' [string "@Interface/AddOns/Blizzard_SharedXML/DataProvider.lua"]:68: in functionInsertAtIndex' [string "@Interface/AddOns/BetterBags/frames/list.lua"]:49: in function AddToStart' [string "@Interface/AddOns/BetterBags/frames/sectionitemlist.lua"]:202: in functionShowCategory' [string "@Interface/AddOns/BetterBags/frames/sectionconfig.lua"]:149: in function <Interface/AddOns/BetterBags/frames/sectionconfig.lua:133>

Locals: (*temporary) =

{ slotIndex = 0 }

Daeadin commented 2 months ago

Qlesz,

Generally speaking, if you have a new issue you should open a separate bug report rather than piggyback on an existing one, as this typically allows the dev to better track and address both issues separately.

On Wed, Sep 4, 2024 at 12:19 PM qlesz @.***> wrote:

V0.3.12 When i try to expand any of the created custom category i get this error now: Message: Interface/AddOns/BetterBags/frames/item.lua:301: bad argument #1 https://github.com/Cidan/BetterBags/issues/1 to 'DoesItemExist' (Usage: local itemExists = C_Item.DoesItemExist(emptiableItemLocation)) Time: Wed Sep 4 19:18:40 2024 Count: 2 Stack: Interface/AddOns/BetterBags/frames/item.lua:301: bad argument #1 https://github.com/Cidan/BetterBags/issues/1 to 'DoesItemExist' (Usage: local itemExists = C_Item.DoesItemExist(emptiableItemLocation)) [string "=[C]"]: in function DoesItemExist' [string @./AddOns/BetterBags/frames/item.lua"]:301: in function GetItemContextMatchResult' [string @./AddOns/Blizzard_ItemButton/Mainline/ItemButtonTemplate.lua"]:462: in function UpdateItemContextMatching' [string @./AddOns/BetterBags/frames/item.lua"]:383: in function SetItemFromData' [string @./AddOns/BetterBags/frames/item.lua"]:285: in function SetStaticItemFromData' [string @./AddOns/BetterBags/frames/itemrow.lua"]:76: in function SetItemFromData' [string @./AddOns/BetterBags/frames/itemrow.lua"]:59: in function SetStaticItemFromData' [string @./AddOns/BetterBags/frames/sectionitemlist.lua"]:147: in function <...terface/AddOns/BetterBags/frames/sectionitemlist.lua:146> [string @./AddOns/BetterBags/data/items.lua"]:847: in function <Interface/AddOns/BetterBags/data/items.lua:839> [string "=[C]"]: in function xpcall' [string @.***/AddOns/Blizzard_ObjectAPI/Mainline/ContinuableContainer.lua"]:83: in function <...Blizzard_ObjectAPI/Mainline/ContinuableContainer.lua:75>

... [string @./AddOns/Blizzard_SharedXML/Shared/Scroll/ScrollBoxListView.lua"]:312: in function DataProviderContentsChanged' [string @./AddOns/Blizzard_SharedXML/Shared/Scroll/ScrollBoxListView.lua"]:303: in function <...izzard_SharedXML/Shared/Scroll/ScrollBoxListView.lua:300> [string "=[C]"]: ? [string @./AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua"]:144: in function <...e/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:143> [string "=[C]"]: ? [string @./AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua"]:147: in function TriggerEvent' [string @./AddOns/Blizzard_SharedXML/DataProvider.lua"]:68: in function InsertAtIndex' [string @./AddOns/BetterBags/frames/list.lua"]:49: in function AddToStart' [string @./AddOns/BetterBags/frames/sectionitemlist.lua"]:202: in function `ShowCategory' [string @./AddOns/BetterBags/frames/sectionconfig.lua"]:149: in function <Interface/AddOns/BetterBags/frames/sectionconfig.lua:133>

Locals: (*temporary) = { slotIndex = 0 }

— Reply to this email directly, view it on GitHub https://github.com/Cidan/BetterBags/issues/674#issuecomment-2329601783, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARMMCQBCSRIZ6FYW27ZAY3LZU46KDAVCNFSM6AAAAABNSZEL62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZGYYDCNZYGM . You are receiving this because you authored the thread.Message ID: @.***>