search

CityOfZion / neo-boa

Python compiler for the Neo2 Virtual Machine, see neo3-boa for NEO3
MIT License
69 stars 55 forks source link

Fixed error with checking if a contract is payable #104

Closed jhwinter closed 6 years ago

jhwinter commented 6 years ago

What current issue(s) from Github does this address?

97 Corresponds to neo-python pull request 660

What problem does this PR solve? GetContract(script_hash).IsPayable currently fails. How did you solve this problem? Changed GetContract(script_hash).IsPayable to GetContract(script_hash).Payable and added a few lines of code to handle IsPayable in expression.py. How did you make sure your solution works? ran make test in my local neo-python project Are there any special changes in the code that we should be aware of? modified ContractTest.py to be simpler Is there anything else we should know? n/a

ixje commented 6 years ago

@jhwinter if you click the little red cross behind your last commit, then you'll go to a page that shows the travis-ci build log and the error(s) thrown.

In this case it can't seem to find wallets. It might be linked to this commit: https://github.com/CityOfZion/neo-python/pull/652/commits/390fd94270700ae69a8a848d5415fd62bdd5c18c

But that would surprise me as neo-python builds fine with that commit, and one thing the neo-python build process does is also test neo-boa to make sure we didn't break anything. Either way it could be a hint where to first look.

localhuman commented 6 years ago

closed in favor of #105