search

Cjewett / HonorAssist

Classic World of Warcraft add-on to track honor gained for the day
4 stars 1 forks source link

Bugfix/regex not language agnostic #15

Closed Cjewett closed 4 years ago

dagochen commented 4 years ago

Message: Interface\AddOns\HonorAssist\HonorAssistToolTip.lua:12: attempt to index a nil value Time: Wed Nov 27 12:45:08 2019 Count: 1 Stack: Interface\AddOns\HonorAssist\HonorAssistToolTip.lua:12: attempt to index a nil value

Interface\AddOns\HonorAssist\HonorAssistToolTip.lua:12: in function <Interface\AddOns\HonorAssist\HonorAssistToolTip.lua:7>

...Ons\ElvUI\Libraries\Ace3\AceHook-3.0\AceHook-3.0.lua:95: in function <...Ons\ElvUI\Libraries\Ace3\AceHook-3.0\AceHook-3.0.lua:87>

...Ons\BootyBayGazette\libs\LibExtraTip\LibExtraTip.lua:482: in function <...Ons\BootyBayGazette\libs\LibExtraTip\LibExtraTip.lua:476>

...Ons\BootyBayGazette\libs\LibExtraTip\LibExtraTip.lua:408: in function <...Ons\BootyBayGazette\libs\LibExtraTip\LibExtraTip.lua:402> C: in function `SetHyperlink' Interface\AddOns\VanasKoS\modules\WarnFrame.lua:145: in function <Interface\AddOns\VanasKoS\modules\WarnFrame.lua:134> Interface\AddOns\VanasKoS\modules\WarnFrame.lua:345: in function <Interface\AddOns\VanasKoS\modules\WarnFrame.lua:344>

Locals:

dagochen commented 4 years ago

everything else should work fine for me

mplachter commented 4 years ago

@dagochen are you saying you pulled this branch and tried it and it was all working well minus the tooltip hover? And yeah thats not working since it doesn't have localization i believe.

mplachter commented 4 years ago

Can you do me a favor and do a /fstack and hover over your target or target of target and get me a spinet of what it displays as.

dagochen commented 4 years ago

i ll do it tomoroww ;)

Cjewett commented 4 years ago

The HonorAssistTooltip.lua code is decoupled from the rest of what this PR is touching. The stack trace has no other files involved, so we shouldn't hold this PR until we fix that issue.

dagochen commented 4 years ago

not sure what information you need, so here is the screenshot:

image