ClementPerroud / Rainbow-Agent

Replicate of Reinforcement Learning Rainbow with Tensorflow 2 from paper "Rainbow: Combining Improvements in Deep Reinforcement Learning"
MIT License
8 stars 7 forks source link

A Mistake in Document #4

Open muhammadali-shahinfar opened 2 months ago

muhammadali-shahinfar commented 2 months ago

Hello @ClementPerroud,

I am grateful for your clean and well-documented open-source Agent!

I noticed a possible mistake in the Rainbow-Agent README.md. In the README, Dueling Networks is defined as "Dividing the neural net stream into two branches, an action stream and a value stream. Both of them combined form the Q-action values." However, this definition is implemented under "adversarial" in the code. Additionally, the provided paper defines Double Q-learning as "reducing overestimations by decomposing the max operation in the target into action selection and action evaluation," which seems to refer to separating the Target model from the main model in agent.py