CliMA / GriddingMachine.jl

Functions to read gridded data so as to feed Clima Land model
Other
35 stars 7 forks source link

Update README.md #74

Closed tomchor closed 2 years ago

tomchor commented 2 years ago

PULL REQUEST

Purpose and Content

@Yujie-W great package! I just downloaded (and started reading) your paper but I noticed you don't yet mention it in the README. This is just a reminder for you to do that so that people can properly cite it :)

Feel free to modify this PR yourself (with a text that's to your liking).

Cheers!

codecov[bot] commented 2 years ago

Codecov Report

Merging #74 (666f5e2) into main (93f9909) will decrease coverage by 1.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   63.94%   62.89%   -1.05%     
==========================================
  Files           6        6              
  Lines         355      380      +25     
==========================================
+ Hits          227      239      +12     
- Misses        128      141      +13     
Impacted Files Coverage Δ
src/Indexer.jl 80.58% <0.00%> (-3.26%) :arrow_down:
src/Collector.jl 92.85% <0.00%> (-1.01%) :arrow_down:
src/Blender.jl 100.00% <0.00%> (ø)
src/Fetcher.jl 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Yujie-W commented 2 years ago

@Yujie-W great package! I just downloaded (and started reading) your paper but I noticed you don't yet mention it in the README. This is just a reminder for you to do that so that people can properly cite it :)

Feel free to modify this PR yourself (with a text that's to your liking).

Thanks. I updated the deps in the docs folder to pass the build (Julia 1.8 does not work with the outdated Netcdf_jll).

Yujie-W commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build succeeded: