Clinical-Genomics-Lund / nextflow_wgs

5 stars 5 forks source link

Sentieon update #131

Closed Jakob37 closed 9 months ago

Jakob37 commented 9 months ago

Description

Reviewer considerations

The most sensitive parts are:

It would be great if these parts were carefully eyed through by another pair of eyeballs.

FIXME:

Close #128

Type of change

Checklist:

Minor change

Post-merge

alkc commented 9 months ago

+1 for chucking qc_sentieon.pl into its own process. That script needs to be gutted and replaced anyway (#80), having it banished/exiled to its own process will make it easier to switch it out.

Jakob37 commented 9 months ago

Onco run QC output looks identical in format (and differing in a handful of mapped reads in the values).

I'll testrun and check the wgs and wgs trio as well

Jakob37 commented 9 months ago

Now it is testrun with wgs single/trio and one onco sample. It runs without any errors and they could be loaded into Scout (into @alkc test instance).

I think this is ready for further investigations now!