Clinical-Genomics-Lund / nextflow_wgs

5 stars 5 forks source link

Jw/update cadd #153

Closed Jakob37 closed 8 months ago

Jakob37 commented 9 months ago

Description

What is changed? What is the result of the changes?

Close #103

Type of change

Checklist:

Minor change

[Optional] Are there any post-deployment tasks we need to perform?

Instructions for the reviewers

How to test the changes

  1. Step 1
  2. Step 2

Expected outcome

[Optional] Additional information

Review

Review performed by:

Testing performed by:

Post-merge

Jakob37 commented 9 months ago

Not ready for review, but relevant for the VEP work.

I'll run tests for this one tonight and tomorrow. Hopefully results are similar ...

Jakob37 commented 9 months ago

v1.7 db prepared, md5sum checked, and tabix indexed

Doing a full run of all PR tests over night. Hopefully things will look good tomorrow and it will be ready for merge into the validation branch.

Jakob37 commented 8 months ago

I am running the stubs as well, but guessing that should look OK. Other testing looks fine.

Ready for review @alkc

Jakob37 commented 8 months ago

Oops, missed updating the version in the table (maybe that should be in the checklist template!)

Will fix it directly in the validation branch

Jakob37 commented 8 months ago

No, wait, this is a db update, the CADD version is for the indel scripts