ViktorHy commented 5 months ago

Description

What is changed? What is the result of the changes?

fixes # (issue)

Type of change

[ ] Major change
[ ] Minor change
[x] Patch
[ ] Documentation

Checklist:

[x] I have updated the CHANGELOG
[x] The latest commit in the master branch is tagged with the correct version number

Patch

[x] Stub run completes without errors or new warnings
[x] At least one other person has reviewed and approved my code

How to test the changes

create_yml.pl for a myeloid-const sample should produce a yaml without images and with owner myeloid

Review

Review performed by:

Reviewer 1: Alexander @alkc

Testing performed by:

Alexander @alkc
Post-merge
[ ] The master branch has been tagged with the new version number.

alkc commented 5 months ago

Code changes look ok.

This is a bit blocked by me trying to work out a test sample. bjorn reanalyze does not really support custom dev assays, which is what I've set up to test this PR.

I'll keep trying.

alkc commented 5 months ago

test run completed. custom_images not added in a myeloid-const reanalyze run.

could not confirm that owner gets the correct value due to running a dev assay, but i'm assuming it works.

Clinical-Genomics-Lund / nextflow_wgs

myeloid-const fixes to match clarity reanalysis #184