Clinical-Genomics-Lund / nextflow_wgs

5 stars 5 forks source link

Mody CF (clean) #201

Closed Jakob37 closed 3 months ago

Jakob37 commented 3 months ago

Description and reviewer info

What is changed? How does this update improve the pipeline? (For reviewers) How to test it?

Close #162

Clean copy of the PR #82

Type of change

Checklist

Documentation

Patch

Major / Minor change

Test/review documentation

Review performed by

(Add if missing)

Testing performed by

Jakob37 commented 3 months ago

I'll copy this from the old PR

Ready for review @ViktorHy

I have stub-run it in the master branch and here for all profiles, and checked that the executed processes are exactly the same.

Would like to discuss the part of the code around freebayes and the subsequent split_normalize at some point. But that is more for my understanding.

Removing the sensitive data is a different story. That will require some thought prior to merge.

Jakob37 commented 3 months ago

Thanks for the review! The tests went through fine. Let's discuss the institute details when we get the chance and wrap things up.