search

CodeMontageHQ / codemontage

CodeMontage empowers coders to improve their impact on the world. Find open source software projects with a social impact and save the world.
http://codemontage.com
GNU General Public License v3.0
80 stars 79 forks source link

Switch from errors to alerts so oauth-related flashes will show #362

Open courte opened 9 years ago

courte commented 9 years ago

Errors weren't showing before, which kept users from seeing helpful information about having a public email address on GitHub and valuable feedback that their login attempt has occurred.

I can't screenshot this change because I don't have a GitHub account that replicates the login error, but testing flashes in the dashboard verified that flash[:error] does not show a result, while flash[:alert] shows up in red at the top of the page.

The other option was to add flash[:error] to the application layout, but it doesn't have the styling that alerts do, so this seemed like the better option.

courte commented 9 years ago

This fix is related to #288. The existing error messages have information about needing a public email address on GitHub, but they are not showing up to users because they're not flashed appropriately.